-
Notifications
You must be signed in to change notification settings - Fork 34
DOP-4904: Inline docs for v1.17 #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and index models
This backports 8f562a701c908b6b7e09e344062094d245050fd3 from master to v1.17
Also consolidates result classes to a single section Backport of 00d44d41a4eb67586207d149d24fd93b1eb5bc6d
Co-authored-by: Nora Reidy <nora.reidy@mongodb.com>
Co-authored-by: Chris Cho <chris.cho@10gen.com>
Snooty does not yet support this.
The bucket-option-codec and collection-option-codec do not inherit common-option-codec since Snooty does not yet support "post" for appending to inherited content. * Note why Bucket's codec option is not passed to CollectionWrapper
Co-authored-by: Mike Woofter <108414937+mongoKart@users.noreply.github.com>
Prefer "extension" over "driver" when referring to ext-mongodb specifically. Also removes mention of Int64 having a private constructor. * PHPLIB-1466: Remove obsolete "Type Map Limitations"
norareidy
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
As part of DOP-4904, this PR inlines the git submodule history into the docs repo for version v1.17. The git history was ported using a small shell script.
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOP-4904
Build Log - https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=66b286ba824f175afd36f7ca
Staging - https://preview-mongodbi80and.gatsbyjs.io/php-library/DOP-4904-v1.17/